Bump to pyo3 0.24 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks, please add a changelog entry and then looks good to merge 👍 |
Collaborator
Author
I looked for one, but I don't think there is a CHANGELOG.md file? Should we create one? |
Member
Collaborator
Author
|
Ah my fork was out of date |
Closed
Collaborator
|
I see @kylebarron has added the changelog entry, the PR looks good and complete. I'll keep the commit title for release in line with what @davidhewitt has been using. Thanks everyone! |
Collaborator
|
I see there's an additional step here, and we need to merge to a specific branch for the release. On this occasion will let @davidhewitt take it from here when he can get to it. |
Member
|
Thanks all, release live! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to pyo3-async-runtimes!
Please consider adding the following to your pull request:
Be aware the CI pipeline will check your pull request for the following:
cargo test)make clippy)cargo fmt)black . --check. You can install black withpip install black)